mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > databasesanitizer.cpp:44 > + struct FileInfo { > + quint32 deviceId; > + quint32 inode; initialize value by default please > databasesanitizer.cpp:107 > + }; > + if ((includeIds.count() > 0 && > !includeIds.contains(info.deviceId)) > + || (excludeIds.count() > 0 && > excludeIds.contains(info.deviceId)) includeIds.count() > 0 => use !isEmpty > databasesanitizer.cpp:153 > + const bool missingOnly, > + const QSharedPointer<QRegularExpression> urlFilter) > +{ const QSharedPointer<QRegularExpression> & ------------------------------------------------------^ > databasesanitizer.cpp:165 > + } else { > + qDebug() << "Skipping" << info.url; > + Q_ASSERT(false); use qCDebug(BALOO) > databasesanitizer.cpp:174 > + } > + err << i18n("Found %1 matching items", infos.count()) << endl; > + as you add a i18n in engine directory you need to extract them. you missed to add a Message.sh in this subdirectory and loading message file. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin