kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land.
Only looked at the diff, but nothing suspicious seen. If it builds and works, should be fine :) Perhaps mention in the commit message also that this moving into the namespace allows to remove DatabaseSanitizer::getDocuments() from the public API, so it gets more clear why this change was done and why there are also those changes in the patch. The reader of this commit in 2 years might be abit thankful :) REPOSITORY R293 Baloo BRANCH namespace REVISION DETAIL https://phabricator.kde.org/D11392 To: michaelh, #baloo, #frameworks, kossebau Cc: kossebau, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin
