michaelh marked 7 inline comments as done.
michaelh added inline comments.
INLINE COMMENTS
> mlaurent wrote in CMakeLists.txt:16
> install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
@mlaurent Is it worth the effort to change this for the other cli tools
accordingly?
> mlaurent wrote in main.cpp:151
> const QString allCommandStr
More const than suggested
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
