cfeck added inline comments.

INLINE COMMENTS

> characterrangescjk.cpp:41
> +        if (c.isLetter() && m_graphemeWords.contains(c.script())) {
> +            result << c;
> +        }

To add a uint to a QStringList, convert the uint character to a QString. Either 
manually compose the surrogates (faster, but uglier code), or use 
QString::fromUcs4() (slower, but nicer to read).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11552

To: michaelh, hein, cfeck
Cc: bruns, lbeltrame, #frameworks, alexeymin, cfeck, ashaposhnikov, michaelh, 
astippich, spoorun, nicolasfella, ngraham

Reply via email to