broulik requested changes to this revision. broulik added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > fileindexerconfig.cpp:63 > , m_indexHidden(false) > - , m_devices(nullptr) > + , m_devices(new StorageDevices(this)) > , m_maxUncomittedFiles(40) Please create the `StorageDevices` object on demand, otherwise this penalizes all users of that class that just want to know whether Baloo itself is enabled, which was the main reason for doing D11279 <https://phabricator.kde.org/D11279> REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: mgallien, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, ngraham, alexeymin
