mwolff added a comment.
the "also" in your commit message: can you split this commit into two parts,
or is the feature addition also fixing the bug? Put differently: Could you
first fix the bug, then add the feature, in separate commits?
INLINE COMMENTS
> kateviewhelpers.cpp:2018
> m_lastClickedLine = t.line();
> - if (positionToArea(e->pos()) != IconBorder &&
> positionToArea(e->pos()) != AnnotationBorder) {
> + auto area = positionToArea(e->pos());
> + if (area != IconBorder && area != AnnotationBorder) {
const
> kateviewhelpers.cpp:2019
> + auto area = positionToArea(e->pos());
> + if (area != IconBorder && area != AnnotationBorder) {
> + auto pos = QPoint(0, e->y());
can you comment this code, why exclude these areas?
> kateviewhelpers.cpp:2183
> const KateTextLayout &t = m_viewInternal->yToKateTextLayout(e->y());
> + auto area = positionToArea(e->pos());
> if (t.isValid()) {
const
> kateviewinternal.cpp:2787
> + placeCursor(pos);
> + m_possibleTripleClick = true;
> +}
dito comment, what has triple click to do with *begin* of select line? Is this
b/c an actual triple click would select the line?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D11685
To: rkron, #frameworks, #kate, #ktexteditor, ngraham, cullmann
Cc: mwolff, richardbowen, ngraham, #ktexteditor, #kate, #frameworks, michaelh,
kevinapavew, demsking, cullmann, sars, dhaumann
