ngraham added a comment.
In D12077#244340 <https://phabricator.kde.org/D12077#244340>, @rkflx wrote: > Okay, did look at the code ;) But please get at least one extra approval from someone else… Yep, was planning on it. In D12077#244339 <https://phabricator.kde.org/D12077#244339>, @rkflx wrote: > Hm, seems like the width of the places panel is set in `kdeglobals` (and too small, BTW) Expect another patch to improve this at some point soon. :) > As for Sorting: If a user does not click on the Configure button which then has "Sorting" in plain sight, why would he click on a Sorting icon? The problem is not that sorting is too hidden, but that users don't get the idea to actually click on any button in the toolbar. Moving sorting does not help at all with that. Well a button with text on a toolbar is more visible than a sub-menu hidden behind a menu hidden behind a text-less button in the corner that currently has an inappropriate icon. But this is a more general problem with KDE-style ToolButtons that... - Don't visibly look like buttons until you hover over them - Don't have text, just an icon - Use a small abstract monochrome line-art icon These buttons don't really communicate "Click me, I'm a button!" like they should. I plan to start a VDG conversation on the subject eventually. > For the view modes it's different, because users recognize the icon from Dolphin. I'd just add the view modes, and IMO sorting in the Detailed View is a good enough compromise. We could think about making this mode the default, because the horizontal scrolling of Short View is kinda difficult to use anyway. Agreed. I was also planning to change the default for Short View to put the icons on top rather than on the side, to match Dolphin's default behavior. That's gated behind a couple of bugs with that view mode that I have to fix first though. Details View as the general default also makes sense for me once D11993 <https://phabricator.kde.org/D11993> lands (without that, it's often almost unusable). REPOSITORY R241 KIO BRANCH show-view-mode-toggles-on-open-save-dialog-toolbar (branched from master) REVISION DETAIL https://phabricator.kde.org/D12077 To: ngraham, #frameworks, rkflx Cc: rkflx, mmustac, broulik, michaelh, ngraham, bruns
