rkflx requested changes to this revision.
rkflx added a comment.
This revision now requires changes to proceed.


  > This also enables it for users who previously disabled it.
  
  Hm, normally changing a default is allowed, while overriding custom user 
settings is discouraged. However, for a `bool` it does not make a difference, 
really ;)
  
  For KConfigXT settings, changing a default is easy, because defaults are not 
repeated in the config file, so it's enough to change the default in the code. 
Here, it's more complicated, as you had to change the name to get that effect.
  
  However, the old key should not stay around in the config file, it should be 
removed. We have `kconf_update` 
<https://techbase.kde.org/Development/Tools/Using_kconf_update> for that. Could 
you provide or update such a script for `~/.config/kdeglobals`?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12328

To: anemeth, #frameworks, #vdg, rkflx
Cc: rkflx, ngraham, #frameworks, michaelh, bruns

Reply via email to