dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed.
This definitely needs a benchmark. (use Q_BENCHMARK in a qtestlib-based unittest) INLINE COMMENTS > mwolff wrote in kcoredirlister.cpp:852 > is it OK that you operate on a copy of the item here? the item in the hash > won't be modified, is that on purpose? That was the case already.... hmm but not in my version of kio. It looks like this patch is on top of other patches. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: mwolff, michaelh, bruns
