romangg added inline comments.
INLINE COMMENTS
> display.h:263
> + /**
> + * Creates the ServerSideDecorationPaletteManagerInterface
> + *
the //XdgOutputManagerInterface//
> xdgoutput_interface.cpp:107
> + });
> + connect(this, &QObject::destroyed, this, [this, output]() {
> + Q_D();
You do not want to connect the destroyed signal of `this` (i.e. the one of the
XdgOuputManagerInterface) here but the one of the new XdgOutputInterface, right?
> xdgoutput_interface.cpp:131
> + auto output = OutputInterface::get(outputResource);
> + if (!output) { // output client is requesting XdgOutput for doesn't exist
> + return;
Comment: `client is requesting XdgOutput for output, that doesn't exist`
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12235
To: davidedmundson, romangg
Cc: #frameworks, michaelh, bruns
