bruns added inline comments.
INLINE COMMENTS
> udisksstorageaccess.cpp:170
> + m_device->invalidateCache();
> m_device->broadcastActionDone("setup");
>
This replaces one race condition with another (less likely) one. There is no
guarantee the property is already updated when checkAccessibility is called.
The correct approach would be to defer until the propertiesChanged signal
arrives and broadcast the "setup done" afterwards.
A different, but more intrusive approach would be to defer any check for the
"acessible" property on the caller side, waiting for the accessibilityChanged
signal.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D12648
To: davidedmundson, #plasma, broulik, mart
Cc: bruns, #frameworks, michaelh
