rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land.
Thanks, LGTM now. INLINE COMMENTS > ngraham wrote in kdiroperator.cpp:1888 > The problem conceptually is that `view-sort-ascending` is semantically > inaccurate for anything but ascending order. We don't actually have an icon > yet that means "general sort options are here!" That's covered by > https://bugs.kde.org/show_bug.cgi?id=393318, and I've pinged Andreas again. > No matter what flawed we choose as a placeholder, I'm going to wait for the > better icon before landing this, so for now let's just leave it the way it is. I think it is a misconception that toolbar icons represent state. I don't know of any toolbar in our software where this is the case, so why should users suddenly expect that what's on the icon represents exactly what is happening, e.g. A-Z ascending? It is merely an example of what type of actions they can expect when clicking on the button. Icons are a symbolic representation of general concept, not a literal display of a specific state. --- Anyway, if you want block everything on that, that's what we'll do. REPOSITORY R241 KIO BRANCH arcpatch-D12337 REVISION DETAIL https://phabricator.kde.org/D12337 To: ngraham, #frameworks, #dolphin, #vdg, rkflx Cc: andreaska, markg, broulik, anemeth, michaelh, bruns
