rkflx added a comment.
In D12734#259445 <https://phabricator.kde.org/D12734#259445>, @muhlenpfordt wrote: > I wanted to be careful here since I'm a bit afraid of changing library functions. If you think it's ok for `Applications/18.04` I'll rebase it. How else would you fix problems in a library ;) Nevertheless, let's check the impact of this again: https://lxr.kde.org/ident?_i=thumbForDirectory Does not look too critical to me, and we probably tested most of the code paths. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D12734 To: muhlenpfordt, #frameworks, rkflx Cc: ngraham, rkflx