bruns added inline comments. Restricted Application added a subscriber: kde-frameworks-devel.
INLINE COMMENTS > mgallien wrote in taglibextractor.cpp:389 > Are you sure we need this cast ? I do not think we will ever need to have > negative track numbers added. The original type is unsigned int and should > exactly convey the fact that we do not expect negative numbers. For CDs, there are hidden tracks, IIRC these have negative numbers. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D11365 To: astippich, #frameworks, #baloo, mgallien, michaelh Cc: kde-frameworks-devel, bruns, michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham
