jtamate updated this revision to Diff 34708. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel.
Based on the tests done in D12945 <https://phabricator.kde.org/D12945> and D11282 <https://phabricator.kde.org/D11282>, the best solution is to have the result of qHash(url) in KFileItem to compare items in the binary search. In two cases, the KFileItem in the list has to be moved to the right position, this is still faster than before. Introduce two methods to insert an item into the list and to move the item to the right position. The crash in kdirmodeltest was due to getting twice the signal of a file changed into a directory. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10742?vs=29572&id=34708 REVISION DETAIL https://phabricator.kde.org/D10742 AFFECTED FILES src/core/kcoredirlister.cpp src/core/kcoredirlister_p.h src/core/kfileitem.cpp src/core/kfileitem.h src/widgets/kdirmodel.cpp To: jtamate, #frameworks, dfaure Cc: kde-frameworks-devel, mwolff, markg, michaelh, ngraham, bruns
