ossi requested changes to this revision. ossi added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > fdreceiver.cpp:34 > { > + const SocketAddress addr(m_path.toLocal8Bit().constData()); > + if (!addr.address()) { it would be more elegant to use m_path.toLocal8Bit().toStdString() here. > fdsender.cpp:29 > { > + const SocketAddress addr(path.c_str()); > + if (!addr.address()) { you're changing the type you're using for the call here. that's a good change, but logically not part of this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns