davidedmundson updated this revision to Diff 35681. davidedmundson marked an inline comment as done. davidedmundson added a comment.
Most review comments As for the locale enum, I'm not sure. I'm working on a QML module and I'm trying to resolve any QML specific issues there rather than complicate these classes. I'll get that onto phab and we can see what ends up being cleanest overall. REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13358?vs=35599&id=35681 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13358 AFFECTED FILES autotests/CMakeLists.txt autotests/knumbermodeltest.cpp src/CMakeLists.txt src/knumbermodel.cpp src/knumbermodel.h To: davidedmundson Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns
