dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks.
See arguments above: If we change it, another one will come over time and submit yet another patch to revert again, and again. This patch cannot go in as is. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12271 To: sraizada, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, dhaumann, anthonyfieroni, #ktexteditor, michaelh, kevinapavew, ngraham, bruns, demsking, head7, cullmann, kfunk, sars, #frameworks