habacker added a comment.

  The macro file uses something like`set(_ki18n_uic_script 
${CMAKE_CURRENT_LIST_DIR}/kf5i18nuic.cmake) ` for two variables, saying that 
the referenced files are located beside the macro file,  but the remaining  
files are based surprisely on a complete different variable, hiding where the 
related files are located really. This patches cleans up this by moving  all 
related files into the build dir, which looks more clean to me. For installing 
local translations it is only required to add <build-dir>/cmake to use the 
macro file and for autotests/ki18n_install.
  
  Furthermore KF5I18n_DIR seems to be required to support 
autotests/ki18n_install, which is a client package using a non standard way to 
use the macro  file from an partially installed ki18n package (some files from 
<build-root>/cmake and some from <src-root>/cmake) , where it would be much 
more standard to use  a full 'find_package' call inside 
(https://cgit.kde.org/ki18n.git/tree/autotests/ki18n_install/CMakeLists.txt) 
only from <build-root>/cmake e.g.
  
    project(ki18n_install)
    cmake_minimum_required(VERSION 3.0)
    
    find_package(KF5I18N)
    
    ki18n_install(${CMAKE_CURRENT_SOURCE_DIR}/po)
  
  BTW: I was faced to this on trying to understand the ki1i8n build system, 
from which I took the macro file and all related dependencies to install po 
files from a tarball released by KDE for a cross build umbrello for Windows 
(see 
https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-umbrello),
 which cant use the full KI18n package for now.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D13406

To: habacker, ilic
Cc: cgiboudeaux, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to