graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision.
REVISION SUMMARY The only usage of widgets was to get the active window. Incorrectly this was done through QWidget which would fail for any application using just QtGui (e.g. QtQuick). As QGuiApplication also provides access to the focus window we can use QtGui API instead. As a note: the whole thing is X11 specific as a window ID is passed to another process, which cannot work on Wayland. It's possible to get it work on Wayland, but that would require: - changes to the dbus protocol - add a dependency to KWayland - or extend QtWayland to generate the required code TEST PLAN Compiles REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 AFFECTED FILES CMakeLists.txt src/solid/CMakeLists.txt src/solid/devices/backends/udisks2/udisksstorageaccess.cpp To: graesslin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns