cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land.
We can keep the dialog stuff ;=) Ok, I pushed the original parts + the status bar stuff. (and a minor fix in updateConfig) Git commit 3f0638e717a990c81fbc248298cc62709e8af851 by Christoph Cullmann, on behalf of Shubham Jangra. Committed on 20/06/2018 at 18:40. Pushed by cullmann into branch 'master'. Implemented displaying of total lines in kate GUI: new option to display total lines in the status bar BUG: 387362 M +3 -0 src/dialogs/katedialogs.cpp M +10 -0 src/dialogs/textareaappearanceconfigwidget.ui M +25 -0 src/utils/kateconfig.cpp M +5 -0 src/utils/kateconfig.h https://commits.kde.org/ktexteditor/3f0638e717a990c81fbc248298cc62709e8af851 Git commit 7651b840075f90e2091903e5d918ad03517fee19 by Christoph Cullmann. Committed on 20/06/2018 at 18:40. Pushed by cullmann into branch 'master'. add context menu to statusbar to toggle show total lines/word count GUI: context menu for status bar to alter settings Differential Revision: https://phabricator.kde.org/D13442 M +32 -0 src/view/katestatusbar.cpp M +3 -0 src/view/katestatusbar.h M +1 -0 src/view/kateview.cpp https://commits.kde.org/ktexteditor/7651b840075f90e2091903e5d918ad03517fee19 > Thanks for the contribution. ============================== REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13442 To: shubham, #ktexteditor, cullmann, brauch Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, kfunk, sars