dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kfilewidget.cpp:1543 > // tokenize() expects it because it uses > QUrl::adjusted(QUrl::RemoveFilename) > + // special cases, avoid transform "<any scheme>:///" into "", > + // that in a file dialog is transformed into user home directory. I think this comment only adds more confusion, because the code doesn't show "" anywhere, it's a side effect of creating an invalid url (or something, I actually wonder why file://// would be invalid...) IMHO it's clear without the added comment. "append slash if needed", and then the if checks if there's already a trailing slash. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13674 To: jtamate, dfaure, #frameworks Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns
