dfaure added a comment.
1. write a unittest for the use case you're trying to solve 2. let's discuss if the use case is valid 3. make the correct, minimal fix, for that use case REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D13627 To: anthonyfieroni, davidedmundson, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns