dschmidt marked an inline comment as done. dschmidt added inline comments. INLINE COMMENTS
> cgiboudeaux wrote in FindIcoTool.cmake:1 > - Missing doc > - Missing license @vpinon Can you let me know what you want here? > cgiboudeaux wrote in ECMAddAppIcon.cmake:105-106 > ECMAddAppIcon has an unit test in tests/ECMAddAppIconTest/ > Please check if you can test the new parameters. Added a test for OUTFILE_BASENAME and WIP for SIDEBAR_ICONS. Need to get my hands on a macOS system to test further... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D13698 To: dschmidt, vonreth, vpinon, apol, alexmerry Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
