ngraham created this revision. ngraham added reviewers: Frameworks, cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision.
REVISION SUMMARY .ico files work fine, so we should allow them to be chosen in the custom icon file chooser dialog/ BUG: 233201 FIXED-IN: 5.48 TEST PLAN - Find a .ico file lying around, or turn a .png file into a .ico file using https://convertico.com/ - Typ to apply it to a folder in Dolphin - You can select the .ico file in the dialog, and when applied, it appears correctly as a custom icon for the folder REPOSITORY R302 KIconThemes BRANCH ico-support-in-icon-file-chooser-dialog (branched from master) REVISION DETAIL https://phabricator.kde.org/D13718 AFFECTED FILES src/kicondialog.cpp To: ngraham, #frameworks, cfeck Cc: kde-frameworks-devel, michaelh, ngraham, bruns