romangg added inline comments.
INLINE COMMENTS
> plasma-virtual-desktop.xml:55
> + <request name="request_activate">
> + <description summary="Requests this desktop to be activated"/>
> + </request>
This needs more description. Other events below as well.
> plasmavirtualdesktop_interface.cpp:181
> +
> +PlasmaVirtualDesktopInterface
> *PlasmaVirtualDesktopManagementInterface::createDesktop(const QString &id)
> +{
What happens on an empty QString argument? I wouldn't allow it and abort with
nullptr returned directly.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D12820
To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh,
ngraham, bruns
