broulik added inline comments.

INLINE COMMENTS

> kmainwindow_unittest.cpp:265
> +        NativeMainWindow *mw = new NativeMainWindow();
> +        connect(mw, &QObject::destroyed, [&](QObject *){ el.exit(); }); // 
> quit event loop when window's gone
> +

connect(mw, &QObject::destroyed, &el, &QEventLoop::quit);

> kmainwindow_unittest.cpp:267
> +
> +        QApplication::postEvent(mw, new QDeferredDeleteEvent);
> +

`mw->deleteLater()`?

> kmainwindow_unittest.cpp:278
> +        el.processEvents();
> +        QVERIFY(mw->m_dock->isVisible() == true);
> +        mw->m_dock->hide();

`QCOMPARE(mw->m-dock->isVisible(), true)`

REPOSITORY
  R263 KXmlGui

BRANCH
  fix-window-state-save

REVISION DETAIL
  https://phabricator.kde.org/D13808

To: maxrd2, #kde_applications, dfaure, elvisangelaccio, broulik, cfeck
Cc: wbauer, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

Reply via email to