elvisangelaccio requested changes to this revision. elvisangelaccio added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > kfileitemmodel.cpp:111 > + > + // warm up the collator so it does not has thread safety problems later > + m_collator.compare(QStringLiteral("aaaaaaaaaaaaaaaaaaaa"), > QStringLiteral("bbbbbbbbbbbbbbbbbbbbbb")); Please explain why we need this workaround here (see my previous comment) REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp