astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.
test itself is fine, but I spotted a typo.
INLINE COMMENTS
> kformattest.cpp:118
> +
> + QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1,
> KFormat::UnitPrefix::Mili, KFormat::MetricBinaryDialect),
> QStringLiteral("10.0 mm"));
> + QCOMPARE(format.formatValue(10.12e-6, KFormat::Unit::Meter, 2,
> KFormat::UnitPrefix::Micro, KFormat::MetricBinaryDialect),
> QStringLiteral("10.12 µm"));
typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it
hasn't been released in its current state, isn't it?
REPOSITORY
R244 KCoreAddons
BRANCH
test1
REVISION DETAIL
https://phabricator.kde.org/D14121
To: bruns, #frameworks, kossebau, astippich
Cc: astippich, kde-frameworks-devel, michaelh, ngraham, bruns
