mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> entryinternal.cpp:495
> if (reader.name() != QLatin1String("stuff")) {
> - qWarning() << "Parsing Entry from invalid XML";
> + qWarning() << "Parsing Entry from invalid XML. Reader tag name was
> expected to be \"stuff\", but was found as:" << reader.name();
> return false;
qCWarning(KNEWSTUFF_CORE) ?
> tagsfilterchecker.cpp:147
> + for(const QString &tag : tags) {
> + if(tag.length() == 0) {
> + // This happens when you do a split on an empty string (not an
> empty list, a list with one empty element... because reasons).
isEmpty() ?
> tagsfilterchecker.cpp:152
> + }
> + QStringList current = tag.split(QStringLiteral("="));
> + if(current.length() > 2) {
use QLatin1Char('=')
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6513
To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent
Cc: mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh,
ZrenBot, bruns
