broulik updated this revision to Diff 38512. broulik retitled this revision from "Port audio notification to libcanberra" to "Support libcanberra for audio notification". broulik edited the test plan for this revision. broulik added a comment.
- Keep Phonon as fallback when libcanberra isn't provided REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14397?vs=38484&id=38512 REVISION DETAIL https://phabricator.kde.org/D14397 AFFECTED FILES CMakeLists.txt cmake/modules/FindCanberra.cmake src/CMakeLists.txt src/knotificationmanager.cpp src/notifybyaudio.cpp src/notifybyaudio.h src/notifybyaudio_canberra.cpp src/notifybyaudio_canberra.h src/notifybyaudio_phonon.cpp src/notifybyaudio_phonon.h To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns