cfeck added inline comments.

INLINE COMMENTS

> kfileplaceeditdialog.h:128
> +     */
> +    bool canEditIcon() const;
>  

Why is this a public API function? If it needs to be public, it should have 
better documentation. There is no 'setIconEditable()' function, so a hint why 
some icons are not editable would be nice.

Also, I would have named it 'isIconEditable()'.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14360

To: shubham, ngraham, broulik, #dolphin, #frameworks, pino
Cc: cfeck, pino, kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to