dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land.
We have done similar things in other frameworks, to indeed make it easier to reuse them in contexts where not all dependencies are wanted. See SONNET_USE_WIDGETS, KSYNTAXHIGHLIGHTING_USE_GUI, KCONFIG_USE_GUI, kxmlgui's FORCE_DISABLE_KGLOBALACCEL, ki18n's BUILD_WITH_QTSCRIPT, KACTIVITIES_LIBRARY_ONLY, KIOCORE_ONLY... Making KF5 frameworks reusable outside of the KDE community was and is still goal number 1 of the rearchitecture (compared to kdelibs4), so I'd say, yes, this change is good. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D12709 To: tundracomp, dfaure Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns
