dhaumann added a comment.
Ok - then with minor changes, let's move this forward. Who is going to do the
work? :-)
INLINE COMMENTS
> kmoretools.cpp:650
> + if (mstruct.mainItems.isEmpty()) {
> + createMoreMenu(mstruct, menu);
> + } else {
This line then changes to d->createMoreMenu(...);
> kmoretools.h:664
> + */
> + void createMoreMenu(const KmtMenuStructure &mstruct, QMenu *parent);
> +
Please move to .cpp file behind the d-pointer.
Reasoning: We usually do not expose private functions in public interafces.
This has slipped for this class in the past it seems, so for KF6, this needs to
be changed anyways. But let's start now: move createMoreMenu() into the cpp
file.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13880
To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
