bruns added a comment.
In D14308#308137 <https://phabricator.kde.org/D14308#308137>, @broulik wrote: > > Should be "Prefer higher BPP" > > That's just the internal changelog on Phabricator. Can we ship this already.. See "Summary: " ... INLINE COMMENTS > icoutils_common.cpp:98 > > - // we loop in reverse order because QtIcoHandler converts all images to > 32-bit depth, and resources are ordered from lower depth to higher depth > - for ( int i_index = icons.size() - 1; i_index >= 0 ; --i_index ) > - { > - > - const QImage &icon = icons.at(i_index); > - int i_width = icon.width(); > - int i_height = icon.height(); > - int i_w = abs(i_width - needWidth); > - int i_h = abs(i_height - needHeight); > - > - if ( i_w < min_w || ( i_w == min_w && i_h < min_h ) ) > - { > + // QtIcoHandler converts all images to 32-bit depth > + // but they store the actual depth of the icon extracted in custom > text: either Qt handler for "Ico" files or qicohandler REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14308 To: broulik, #frameworks, dfaure, ngraham, pali, vonreth, antlarr, bruns Cc: anthonyfieroni, bruns
