cullmann requested review of this revision. cullmann added a comment.
There is one tiny problem with that change: The compression filter device crashs sometimes, if you have bad luck, e.g. tried like David did show above with a small tmp mount: ASSERT: "d->avail_out > 0" in file /home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp, line 128 Thread 1 "kwrite" received signal SIGABRT, Aborted. 0x00007ffff156708b in raise () from /lib64/libc.so.6 (gdb) bt #0 0x00007ffff156708b in raise () from /lib64/libc.so.6 #1 0x00007ffff15504e9 in abort () from /lib64/libc.so.6 #2 0x00007ffff22b022b in QMessageLogger::fatal(char const*, ...) const () from /usr/lib64/libQt5Core.so.5 #3 0x00007ffff22af7d9 in qt_assert(char const*, char const*, int) () from /usr/lib64/libQt5Core.so.5 #4 0x00007ffff04b44fb in KNoneFilter::copyData (this=0x7fffdc0278f0) at /home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp:128 #5 0x00007ffff04b44c6 in KNoneFilter::compress (this=0x7fffdc0278f0, finish=true) at /home/cullmann/kde/src/frameworks/karchive/src/knonefilter.cpp:123 #6 0x00007ffff04b277e in KCompressionDevice::writeData (this=0x7fffffffc220, data=0x0, len=0) at /home/cullmann/kde/src/frameworks/karchive/src/kcompressiondevice.cpp:343 #7 0x00007ffff23ddddd in QIODevice::write(char const*, long long) () from /usr/lib64/libQt5Core.so.5 #8 0x00007ffff04b1f1d in KCompressionDevice::close (this=0x7fffffffc220) at /home/cullmann/kde/src/frameworks/karchive/src/kcompressiondevice.cpp:165 #9 0x00007ffff77ee7fd in Kate::TextBuffer::save (this=0x72a930, filename=...) at /home/cullmann/kde/src/frameworks/ktexteditor/src/buffer/katetextbuffer.cpp:858 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D14890 To: cullmann, dhaumann, dfaure Cc: dfaure, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann