ngraham accepted this revision. ngraham added reviewers: Frameworks, cfeck. ngraham added a comment. This revision is now accepted and ready to land.
Works great and looks fine to me, and the code seems sensible too given that this dialog is currently implemented with a GridLayout. I'd like to see this ported to use a FormLayout at some point, which is both more semantically appropriate, and would also simplify this type of code. But that's material for another patch of course. :) Please wait for at least one more review before landing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15000 To: shubham, dfaure, broulik, ngraham, #frameworks, cfeck Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns
