bruns added inline comments.

INLINE COMMENTS

> run-sip.py:11
> +    from PyQt5.Qt import PYQT_CONFIGURATION
> +    pyqt_sip_flags = PYQT_CONFIGURATION["sip_flags"].split(' ')
> +    index_n = pyqt_sip_flags.index('-n')

Is there a gurantee `-n` and its arg are space separated?

otherwise:

  import re
  m = re.search('-n\s*(\S+)', PYQT_CONFIGURATION["sip_flags"])
  if m:
    sipArgs = ['-n', m.group(1)] + sipArgs

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D15091

To: arojas, #frameworks, bruns
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Reply via email to