cullmann added a comment.
Regarding implicit sharing, is this actually shared between two (subsequent) lines with the same state (think of e.g. a multi-line license header block)? Then it might be interesting to keep it, otherwise I agree, the increased control of a std::vector might be preferable here indeed. At the moment, KTextEditor compares the returned states and reuses the input state. I would do the same in highlightLine, then you get that for free. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15134 To: cullmann, vkrause, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann
