jtamate marked 2 inline comments as done.
jtamate added inline comments.

INLINE COMMENTS

> broulik wrote in kioexecd.cpp:58
> I'm not sure that's a good idea

Why not?
It should be just removing the temporary file copy and it's backups.

> broulik wrote in kioexecd.cpp:73
> You never unwatch the dir

No, only at the destructor, unless there is a way to know when the program that 
uses the file has been closed, I guess keeping the file during all the session 
is the same behavior as before.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15180

To: jtamate, #frameworks, broulik, ngraham, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Reply via email to