jtamate marked an inline comment as done. jtamate added inline comments. INLINE COMMENTS
> elvisangelaccio wrote in kioexecd.cpp:129 > Maybe `constBegin()`/`constEnd()` here? I always thought const iterators were meant to be used when the whole container is considered ReadOnly, not only its elements, looks like the compiler agrees: kioexecd.cpp:138:36: error: no matching function for call to ‘QMap<QString, QDateTime>::erase(QMap<QString, QDateTime>::const_iterator&)’ REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15180 To: jtamate, #frameworks, broulik, ngraham, dfaure, elvisangelaccio Cc: bruns, anthonyfieroni, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham