broulik added inline comments.
INLINE COMMENTS
> kfilewidget.cpp:440
> + connect(d->ops, &KDirOperator::urlEntered, this,
> + [&](const QUrl &url){d->_k_urlEntered(url);});
> + connect(d->ops, &KDirOperator::fileHighlighted, this,
Shouldn't this be using the `url` from the signal?
Also, please prefer explicit captures over `&` or `=`
> kfilewidget.cpp:473
>
> QAction *goToNavigatorAction =
> coll->addAction(QStringLiteral("gotonavigator"), this,
> SLOT(_k_activateUrlNavigator()));
> goToNavigatorAction->setShortcut(QKeySequence(Qt::CTRL + Qt::Key_L));
Why not change this as well?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D15328
To: jtamate, dfaure, #frameworks
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns
