dvratil requested changes to this revision. dvratil added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > personactionsmodel.cpp:21 > #include <kpeople/persondata.h> > -#include <kpeople/actions.h> > +#include <kpeople/widgets/actions.h> > #include <QAction> This looks suspicious. When compiling, you should not need to refer to `<kpeople/...>`, the includes should actually be #include "persondata.h" #include "widgets/actions.h" otherwise, there's a risk that a wrong header gets included from installed KPeople instead of from the source tree. I suspect this module lived elsewhere and got just moved into KPeople without adjusting the includes. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D15497 To: poboiko, #frameworks, dvratil, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns
