ngraham added a comment.
@shubham, in the future, when there are still reviewers who have marked their status as "Request Changes", please wait for them to approve before pushing. Since that didn't happen this time, if @pino or @dfaure have any remaining concerns with this patch, please submit a follow-up patch to address their feedback. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14757 To: shubham, pino, dfaure, broulik, ngraham Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns