svuorela added inline comments.
INLINE COMMENTS
> taglibwritertest.cpp:66
> + QCOMPARE(extractedGenre, QString(QStringLiteral("Genre1") +
> stringSuffix));
> + QCOMPARE(extractedComment, QString(QStringLiteral("Comment1") +
> stringSuffix));
>
I suggest checking that the last bytes of all these extracted things is the
actual actual utf8 bytes, so that if someone compiles or saves this file in a
broken encoding that the testing doesn't fail.
> taglibwritertest.cpp:75
> QTest::addColumn<QString>("mimeType");
> + QTest::addColumn<QString>("stringSuffix");
>
Given stringSuffix is the same for all tests, is it needed to have as a test
data thing ?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D15714
To: astippich, mgallien, bruns
Cc: svuorela, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
