ngraham added a comment.
In D15739#331700 <https://phabricator.kde.org/D15739#331700>, @davidedmundson wrote: > They don't. > > Why are you changing the if (windows) code path above the elif? Because that's the windows equivalent of adding Root. I reasoned that if we don't want to show a Places panel entry for Root on Linux, then for similar reasons we wouldn't want to create Places panel entries for Windows disks when on Windows. Don't disks show up in the Devices section on Windows like they do on Linux? Can't test, sorry. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15739 To: ngraham, #dolphin, #vdg, davidedmundson Cc: davidedmundson, abetts, svenmauch, broulik, acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns