bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision.
REVISION SUMMARY Each notification was created as new datasource, and was newer removed as long as the engine exists. This is especially bad for long living applets like the device notifier. As there can only be one notification per device (the last error state, or none), use the UDI as source name and update the contents. Also cancel (remove source) an old notifications in case of a successful setup, otherwise old error messages are shown in the device notifier. TEST PLAN in Dolphin, select "Release" (context menu) for a mounted CD -> Notification in device notifier appears "Device can be safely removed" remount without ejecting -> Notification message is removed, device shows "mounted" emblem. Without the change, the message stayed and the device kept the notification emblem "(!)". REPOSITORY R120 Plasma Workspace BRANCH device_notifier_qml_fix2 REVISION DETAIL https://phabricator.kde.org/D15892 AFFECTED FILES dataengines/devicenotifications/devicenotificationsengine.cpp dataengines/devicenotifications/devicenotificationsengine.h dataengines/devicenotifications/ksolidnotify.cpp dataengines/devicenotifications/ksolidnotify.h To: bruns, #frameworks Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart