dfaure added a comment.
This looks like the kind of commit where a review by Oswald Buddenhagen
<o...@kde.org> would be useful.
INLINE COMMENTS
> kcrash.cpp:672
> + // wait while DrKonqi is running and the socket connection
> exists
> + while (kill(pid, 0) >= 0 && pollDrKonqiSocket(pid, sockfd)
> >= 0);
> + closeDrKonqiSocket(socketpath, sockfd);
Use {} rather than ';' for the body of the while loop, otherwise many tools
(and humans...) will think the ';' is an error.
REPOSITORY
R285 KCrash
REVISION DETAIL
https://phabricator.kde.org/D11236
To: croick, #frameworks
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh,
ngraham, bruns
