mgallien added inline comments. INLINE COMMENTS
> embeddedimagedata.h:62 > + */ > + QStringList readMimetypes() const; > + You can make it static because you are returning a static member. It means that you should probably return by const reference (even if I do not remember if it is always the best answer). REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16197 To: astippich, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams