aacid added a comment.
Yep, this looks more like it :) You're missing @since markers (in the documentation of the new functions) for the KF5 version this will be introduced, but i'd say let's wait for someone to give the final approval and then you remember to commit the correct version number for them? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D16137 To: kadabash Cc: ngraham, svuorela, aacid, kde-frameworks-devel, michaelh, bruns